Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyPy CI Specifier #467

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Update PyPy CI Specifier #467

merged 2 commits into from
Oct 14, 2021

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Oct 14, 2021

pypy3 is being deprecated as a specifier, see actions/setup-python#244. Right now this affects macos-latest, but I imagine it will percolate through the other os images as well. The current CI here has not failed, I think because the image is cached.

@mattip mattip force-pushed the pypy-ci branch 2 times, most recently from 90bf597 to d4887f1 Compare October 14, 2021 20:37
@mattip
Copy link
Contributor Author

mattip commented Oct 14, 2021

I am not well-versed in nox. The github setup-python specifier is now pypy-3.7, the executable in the created environment can be one of pypy3, pypy3.7, pypy, python, python3, or python3.7. Is nox looking for pypy-3.7? That is not one of the options.

@mattip mattip force-pushed the pypy-ci branch 3 times, most recently from f3a47ad to 7400644 Compare October 14, 2021 21:39
@mattip
Copy link
Contributor Author

mattip commented Oct 14, 2021

Adding another if clause did the trick

In the end the old invocation was correct

Co-authored-by: Pradyun Gedam <[email protected]>
@pradyunsg pradyunsg closed this Oct 14, 2021
@pradyunsg pradyunsg reopened this Oct 14, 2021
@pradyunsg
Copy link
Member

You didn't modify any .py files, so the required runs aren't running anymore. 🤣

It's fine though -- I can tick the admin checkbox and merge this.

@pradyunsg pradyunsg changed the title update pypy ci specifier Update PyPy CI Specifier Oct 14, 2021
@pradyunsg pradyunsg merged commit 42e1396 into pypa:main Oct 14, 2021
@mattip mattip mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants