Wheel spec: Update rules on escaping components of wheel filename #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Feb 28, 2021
FFY00
approved these changes
Feb 28, 2021
pfmoore
requested changes
Feb 28, 2021
| characters should be replaced with ``_`` (LOW LINE). Normalised version | ||
| numbers cannot contain ``_``, so the replacement does not lose information. | ||
| - The remaining components may not contain ``-`` characters, so no escaping | ||
| is necessary. |
There was a problem hiding this comment.
I personally feel that we should require tools generating wheels to fail with an error if the above rules result in any component still containing a dash, just as a last-ditch safety measure to protect against future standards changes failing to take the wheel naming requirements into account, but no-one else seemed too interested in that, so I'll let it drop at this point.
pfmoore
approved these changes
Feb 28, 2021
flying-sheep
added a commit
to flying-sheep/flit
that referenced
this pull request
Mar 1, 2021
According to new rules in https://packaging.python.org/specifications/binary-distribution-format/#escaping-and-unicode Specifically the ones introduced in pypa/packaging.python.org#844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion at https://discuss.python.org/t/escaping-versions-for-wheel-sdist-and-dist-info-names/5605
These are the same rules as for .dist-info directories, specified in recording installed packages, but with a bit more description for names.