Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add manylinux_2_28 image #1277

Merged
merged 1 commit into from
May 30, 2022
Merged

feature: add manylinux_2_28 image #1277

merged 1 commit into from
May 30, 2022

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Feb 5, 2022

fix #1282

Add manylinux_2_28 images based on AlmaLinux 8.
The following architectures are supported:

  • x86_64
  • aarch64
  • ppc64le

s390x might be added later on depending on availability of a base image.
i686 won't be added.

@mayeut mayeut force-pushed the manylinux_2_28 branch 2 times, most recently from 97aebb0 to 5a5fa1d Compare February 12, 2022 18:02
@mattip
Copy link
Contributor

mattip commented Feb 13, 2022

Wheels built with this image for x86_64 are at https://github.com/mattip/numpy/actions/runs/1836100699. In the artifact section at the bottom, the cp3*-manylinux_x86_64.zip files each contain a wheel.

@mayeut
Copy link
Member Author

mayeut commented Feb 13, 2022

So all builds & tests seem to be ok !
I did not know NumPy was using cibuildwheel (although I guess just for testing, not for official wheels which still use multibuild ?)
I admit I was not too worried about numpy x86_64 as it's C only on the most tested architecture.
I added some alt-arch images (& moved the x86_64 one):

  • quay.io/pypa/manylinux_2_28_poc_x86_64:poc
  • quay.io/pypa/manylinux_2_28_poc_ppc64le:poc
  • quay.io/pypa/manylinux_2_28_poc_aarch64:poc

I might be able to create a PR at https://github.com/MacPython/openblas-libs to see if alt-arch build properly with these images.

@mattip
Copy link
Contributor

mattip commented Feb 13, 2022

NumPy was using cibuildwheel

The goal is to move to cibuildwheel for the next release (in July), and to move SciPy to cibuildwheel too.

I might be able to create a PR at https://github.com/MacPython/openblas-libs

cool, that would be nice

@mayeut mayeut marked this pull request as ready for review May 28, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for manylinux_2_28 image
4 participants