-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include schemes with records, when calling finalise_installation
#75
Conversation
This is needed for the bytecode generation step afterwards. This commit is/was part of #66 but I have created a separate PR to speed up review. This is the only thing preventing me from providing a CLI in a 3rd party package. |
4654baf
to
13b8204
Compare
6306a5c
to
9cedef5
Compare
f879826
to
5291351
Compare
@pradyunsg friendly ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, although I'd strongly prefer to not have a mapping here.
I'll cut a 0.4.0 with this, once that is changed, that is Python 2 compatible -- only because you're nice and have been super helpful with this project. :)
Thank you, I will have a look tomorrow. |
Signed-off-by: Filipe Laíns <[email protected]>
5291351
to
118a59a
Compare
Sorry for the delay. |
finalise_installation
finalise_installation
finalise_installation
No worries! ^>^ Here you go: https://pypi.org/project/installer/0.4.0/ |
Signed-off-by: Filipe Laíns [email protected]