Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Docker image and push to GHCR #230
Build Docker image and push to GHCR #230
Changes from all commits
783267b
e453f8c
0d8d505
aed6c4b
f1f014b
cf5ce17
5ded531
a869dd3
a360fcb
f51682f
7ea8313
bacb626
d03addb
153ccde
cfb9d93
1b9f21a
80b1d50
da55441
36965cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@br3ndonland when running in another repo, wouldn't
github.ref_name
point to that repo instead of ours? Is it safe to use this var as a fallback? Same question forgithub.event.pull_request
. Is this to cover contributions to the action itself?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If another repo is using the marketplace action (
uses: pypa/gh-action-pypi-publish
),env.ACTION_REF
will be set fromgithub.action_ref
.If the action is being run on a PR to this repo,
env.PR_REF
will be set fromgithub.event.pull_request.head.ref
.If the action is being run from a push, release, or other event in this repo,
github.ref_name
will be used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Thanks for clarifying. So I'll need to be careful in the release process to make an image before tagging…