Rework the automation for generating the scripts #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reintroduces the logic we had for generating our get-pip.py scripts with 3 major changes: - drop dependency on invoke. - add caching using requests and cachecontrol. - setup a nox session to orchestrate everything.
pradyunsg
force-pushed
the
rework-how-stuff-works
branch
from
dcdbefd
to
8606c71
Compare
This handles all the git interactions as well, simplifying the process for whoever makes a pip release.
pradyunsg
force-pushed
the
rework-how-stuff-works
branch
from
8606c71
to
726ff7b
Compare
|
I'm likely going to be merging this over the coming weekend, since I'd like to get around to cleaning up the error messaging situation we have, and I don't want to touch the templates in this PR. :) |
|
@pypa/pip-committers I've changed the automation for this repository here, and the documentation has been updated as well. |
This was referenced Feb 21, 2021
Closed
This was referenced Mar 6, 2021
This was referenced Apr 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a rewrite of the entire automation in the repository. We're still doing the exact same things, but the plumbing is different now.
nox -s generatewhich handles generating the script.nox -s update-for-releasewhich does everything that a pip release manager might want to do.nox -s checkwhich ensure that the scripts do install pip. :)The automation is now broken up into smaller composable functions, that each does one this. This should make it easier to tweak how stuff works in the future (like for #61 😉).