flit_core: Normalize sdist names according to PEP 625 #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize generated source distribution names using the same rules as wheels, as required by PEP 625 [1]. This aligns flit_core with other modern PEP 517 backends such as hatchling. [1] https://peps.python.org/pep-0625/ Fixes pypa#626
|
I kinda suspect that it was too easy ;-). |
|
@takluyver, ping. |
|
Thanks! I know what you mean that it seems too easy, but I can't see anything wrong, so 🤞 it's OK. Sorry it's taken me a while to look at it. |
|
Thanks! I suppose it's just that things are easy when software is well-written! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize generated source distribution names using the same rules as wheels, as required by PEP 625 [1]. This aligns flit_core with other modern PEP 517 backends such as hatchling.
[1] https://peps.python.org/pep-0625/
Fixes #626