Let _show_help() use commands instead of self.commands #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the context, _show_help() is called with a different commands argument. I believe the intent was to adapt the help message to the context. However, it would operate on self.commands instead of the commands argument, which would break this purpose.
DimitriPapadopoulos
force-pushed
the
_show_help
branch
from
984c19f
to
40c56e2
Compare
jaraco
approved these changes
Aug 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the context, _show_help() is called with a different commands argument. I believe the intent was to adapt the help message to the context. However, it would operate on self.commands instead of the commands argument, which would break this purpose.
Fixes #242.