ci: release to PyPI from CI on GitHub Release #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should avoid variance in local environments when releasing. Needs #893 to producing working SDists/wheels. Should help avoid #892 in the future. You can also download the SDist/wheel from PRs (since it's likely much, much faster than our CI, I don't think it hurts to leave this on for all PRs, we could even enable for the main branch).
Note that anyone who can make a GitHub release can make a PyPI release. Feel free to restrict as needed. Also a token needs to be generated and added to secrets with the name
pypi_password.