Improve diagnostics when auditwheel repair fails #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarlow83
force-pushed
the
pr-auditwheel-diag
branch
from
704ebf4 to
f23c006
Compare
henryiii
reviewed
Aug 27, 2021
cibuildwheel/linux.py
Outdated
Comment on lines
314
to
318
| def matches_prepared_command(error_cmd: List[str], command_template: str) -> bool: | ||
| if len(error_cmd) < 3 or error_cmd[0:2] != ["sh", "-c"]: | ||
| return False | ||
| command_prefix = command_template.split("{", maxsplit=1)[0].strip() | ||
| return error_cmd[2].startswith(command_prefix) |
There was a problem hiding this comment.
Does this need to be inside another function? Is it capturing anything? If not, it really needs to be moved out. Functions-in-functions should always capture scope (and functions should not capture scope - using partials is easier to follow). It can start with an underscore to indicate its "private".
There was a problem hiding this comment.
Fair enough. I wrote it as a closure, mypy didn't understand it unfortunately :/.
jbarlow83
force-pushed
the
pr-auditwheel-diag
branch
from
f23c006 to
2253d0c
Compare
jbarlow83
force-pushed
the
pr-auditwheel-diag
branch
from
045588c to
31646fb
Compare
joerick
approved these changes
Aug 28, 2021
There was a problem hiding this comment.
Thanks @jbarlow83 !
I just added a test for this and improved the existing test to add the counterfactual.
joerick
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #793