-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update expected wheels when using auditwheel >= 4 #633
Conversation
Ouch! This means that all older versions of pip will not be able to load wheels! Is there a way to get the old name back? The main reason to produce manylinux1 (and manylinux2010, mostly) is for old pip versions. The double-tagging seems useful, but not the name change to something pip 9, 10, ..., 20? cannot load. |
@henryiii, they will be able to load those per the wheel spec (and I verified this). |
How do they know how to load a wheel with a name on a spec that was invented after pip was released? (Not saying they don't, just have had to fight to get macOS wheels to have the right names (pip 21.0.1+ only), so wondering how this works) |
Per the wheel spec, the platform tag shall be split by |
Ahh, I missed that the the |
old macos wheels has multiple platform tags. Maybe because of this pip still could handle it. |
This was my own confusion. I though it was making |
Nice one, thanks for checking this @mayeut ! |
caf5bc2
to
733924d
Compare
Force installing auditwheel in previous iterations of the PR masked the fact that we'd need an updated PyPy image as well (I'd really like to avoid a ugly hack for PyPy, even if just for testing). Need to wait for pypy/manylinux#16 |
Maybe the tests should support either version for a while to ease the transition. Maybe use Then we can try to work on moving to version 4 uniformly if possible, as it would be nice to have the names match, but if PyPy was the odd one out for a bit, we might be able to live with that? |
PyPy3.7 7.3.4 has been fixed and does not require the patch anymore.
Now that pypy/manylinux#16 has been merged, workarounds are limited to |
I need this in for #666 |
This only touches tests and standard dependency updates, so I think it's safe to merge. |
auditwheel
>= 4 has major changes that needs to be reflected incibuildwheel
tests:auditwheel
always outputs the PEP 600 platform tag (e.g.foo-1.0-cp37-cp37m-manylinux1_x86_64.whl
becomesfoo-1.0-cp37-cp37m-manylinux_2_5_x86_64.manylinux1_x86_64.whl
)auditwheel
now only outputs 1 wheel. Compatibility with a previous policy is now reflected in the wheel filename (e.g. instead of 2 wheelsfoo-1.0-cp37-cp37m-manylinux1_x86_64.whl
&foo-1.0-cp37-cp37m-manylinux2014_x86_64.whl
, we get 1 wheelfoo-1.0-cp37-cp37m-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
). Opting out of previous policy compatibility is done by using the--only-plat
flag.