-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pinned default manylinux2010 image version #472
Conversation
The current pinned version of the manylinux2010 docker image has an issue where it is trying to use EoL yum repositories (see pypa/manylinux#836 for more details). The repository path has been updated on the latest image. This commit bumps the manylinux2010 docker image version to use the latest version to get this fix.
The default version of the manylinux2010 docker images used by cibuildwheel are trying to use a nonexistent yum repository now that centos 6 is eol. The latest version of the docker image has been updated. This commit manually sets the docker image to the latest version to unblock CI. This PR can be reverted when cibuildwheel releases a new version that bumps their default manylinux2010 version (see pypa/cibuildwheel#472 for more details on that).
Let's bump all images, then? |
From what I can tell only manylinux2010 has newer images (since it's the only one built on centos 6). Looking at manylinux2014 https://quay.io/repository/pypa/manylinux2014_x86_64?tab=tags and manylinux1 https://quay.io/repository/pypa/manylinux1_x86_64?tab=tags the latest is 11-11 |
You're right. I just ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 1.7.1, @joerick?
The default version of the manylinux2010 docker images used by cibuildwheel are trying to use a nonexistent yum repository now that centos 6 is eol. The latest version of the docker image has been updated. This commit manually sets the docker image to the latest version to unblock CI. This PR can be reverted when cibuildwheel releases a new version that bumps their default manylinux2010 version (see pypa/cibuildwheel#472 for more details on that).
I have a feeling this updated after 1.7.0, since I remember seeing the PR with the dependency update. |
🤦♂️ You're right: #467. And obviously, |
@mtreinish, do note that you can override these pinned manylinux images, btw, if you need this change reasonably urgently: https://cibuildwheel.readthedocs.io/en/stable/options/#manylinux-image |
Yep, already did :) Qiskit/rustworkx#212 and Qiskit/qiskit-aer#1066 just wanted to make sure that things got updated for everyone |
Thanks! :-) |
thanks all! I'll push a new release now |
released as v1.7.1 |
The linux wheels we publish to PyPI at release time are based on the manylinux1 [1] and manylinux2010 [2] packaging specifications. To build these wheels we use the manylinux2010 docker image [3] which is based on centos 6. Centos 6 recently went end of life and the yum repositories for it were deleted and an archive url for the yum repositories were added. However, until the latest manylinux2010 docker image, the images were configured to use the old url from when the distro was still supported by upstream. This causes issues when trying to setup a build [4] because yum will error early during the initial job setup. To fix this we need to ensure we're using the latest version of the manylinux 2010 docker image, we can either do this manually (as was done in Qiskit/rustworkx#212 and Qiskit/qiskit-aer#1066) or just update the cibuildwheel version we're using to the latest release 1.7.1 which bumped the pinned manylinux2010 docker image used to one with updated yum urls (see pypa/cibuildwheel#472). This commit bumps the cibuildwheel version to the latest release so that when it is time to release terra 0.17.0 the jobs will work as expected. [1] https://www.python.org/dev/peps/pep-0513/ [2] https://www.python.org/dev/peps/pep-0571/ [3] https://github.com/pypa/manylinux [4] pypa/manylinux#836
* Bump cibuildwheel to latest version The linux wheels we publish to PyPI at release time are based on the manylinux1 [1] and manylinux2010 [2] packaging specifications. To build these wheels we use the manylinux2010 docker image [3] which is based on centos 6. Centos 6 recently went end of life and the yum repositories for it were deleted and an archive url for the yum repositories were added. However, until the latest manylinux2010 docker image, the images were configured to use the old url from when the distro was still supported by upstream. This causes issues when trying to setup a build [4] because yum will error early during the initial job setup. To fix this we need to ensure we're using the latest version of the manylinux 2010 docker image, we can either do this manually (as was done in Qiskit/rustworkx#212 and Qiskit/qiskit-aer#1066) or just update the cibuildwheel version we're using to the latest release 1.7.1 which bumped the pinned manylinux2010 docker image used to one with updated yum urls (see pypa/cibuildwheel#472). This commit bumps the cibuildwheel version to the latest release so that when it is time to release terra 0.17.0 the jobs will work as expected. [1] https://www.python.org/dev/peps/pep-0513/ [2] https://www.python.org/dev/peps/pep-0571/ [3] https://github.com/pypa/manylinux [4] pypa/manylinux#836 * DNM: test wheel jobs * Revert "DNM: test wheel jobs" This reverts commit b63071a. Co-authored-by: Kevin Krsulich <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
The default version of the manylinux2010 docker images used by cibuildwheel are trying to use a nonexistent yum repository now that centos 6 is eol. The latest version of the docker image has been updated. This commit manually sets the docker image to the latest version to unblock CI. This PR can be reverted when cibuildwheel releases a new version that bumps their default manylinux2010 version (see pypa/cibuildwheel#472 for more details on that).
The default version of the manylinux2010 docker images used by cibuildwheel are trying to use a nonexistent yum repository now that centos 6 is eol. The latest version of the docker image has been updated. This commit manually sets the docker image to the latest version to unblock CI. This PR can be reverted when cibuildwheel releases a new version that bumps their default manylinux2010 version (see pypa/cibuildwheel#472 for more details on that).
The default version of the manylinux2010 docker images used by cibuildwheel are trying to use a nonexistent yum repository now that centos 6 is eol. The latest version of the docker image has been updated. This commit manually sets the docker image to the latest version to unblock CI. This PR can be reverted when cibuildwheel releases a new version that bumps their default manylinux2010 version (see pypa/cibuildwheel#472 for more details on that).
The default version of the manylinux2010 docker images used by cibuildwheel are trying to use a nonexistent yum repository now that centos 6 is eol. The latest version of the docker image has been updated. This commit manually sets the docker image to the latest version to unblock CI. This PR can be reverted when cibuildwheel releases a new version that bumps their default manylinux2010 version (see pypa/cibuildwheel#472 for more details on that).
The default version of the manylinux2010 docker images used by cibuildwheel are trying to use a nonexistent yum repository now that centos 6 is eol. The latest version of the docker image has been updated. This commit manually sets the docker image to the latest version to unblock CI. This PR can be reverted when cibuildwheel releases a new version that bumps their default manylinux2010 version (see pypa/cibuildwheel#472 for more details on that).
The current pinned version of the manylinux2010 docker image has an
issue where it is trying to use EoL yum repositories
(see pypa/manylinux#836 for more details). The repository path has been
updated on the latest image. This commit bumps the manylinux2010 docker
image version to use the latest version to get this fix.