Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pinned default manylinux2010 image version #472

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

mtreinish
Copy link
Contributor

The current pinned version of the manylinux2010 docker image has an
issue where it is trying to use EoL yum repositories
(see pypa/manylinux#836 for more details). The repository path has been
updated on the latest image. This commit bumps the manylinux2010 docker
image version to use the latest version to get this fix.

The current pinned version of the manylinux2010 docker image has an
issue where it is trying to use EoL yum repositories
(see pypa/manylinux#836 for more details). The repository path has been
updated on the latest image. This commit bumps the manylinux2010 docker
image version to use the latest version to get this fix.
mtreinish added a commit to mtreinish/qiskit-aer that referenced this pull request Dec 3, 2020
The default version of the manylinux2010 docker images used by
cibuildwheel are trying to use a nonexistent yum repository now that
centos 6 is eol. The latest version of the docker image has been
updated. This commit manually sets the docker image to the latest
version to unblock CI. This PR can be reverted when cibuildwheel
releases a new version that bumps their default manylinux2010 version
(see pypa/cibuildwheel#472 for more details on that).
@YannickJadoul
Copy link
Member

Let's bump all images, then?
Also, seems this was forgotten when releasing 1.7.0? :-(

@mtreinish
Copy link
Contributor Author

Let's bump all images, then?

From what I can tell only manylinux2010 has newer images (since it's the only one built on centos 6). Looking at manylinux2014 https://quay.io/repository/pypa/manylinux2014_x86_64?tab=tags and manylinux1 https://quay.io/repository/pypa/manylinux1_x86_64?tab=tags the latest is 11-11

@YannickJadoul
Copy link
Member

You're right. I just ran bin/update_dependencies.py, and only this one has been updated indeed!
Apologies; most of the time all images get updated :-)

Copy link
Member

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 1.7.1, @joerick?

vvilpas pushed a commit to Qiskit/qiskit-aer that referenced this pull request Dec 3, 2020
The default version of the manylinux2010 docker images used by
cibuildwheel are trying to use a nonexistent yum repository now that
centos 6 is eol. The latest version of the docker image has been
updated. This commit manually sets the docker image to the latest
version to unblock CI. This PR can be reverted when cibuildwheel
releases a new version that bumps their default manylinux2010 version
(see pypa/cibuildwheel#472 for more details on that).
@henryiii
Copy link
Contributor

henryiii commented Dec 3, 2020

I have a feeling this updated after 1.7.0, since I remember seeing the PR with the dependency update.

@YannickJadoul
Copy link
Member

🤦‍♂️ You're right: #467. And obviously, 2020-12-03 is very much today. I must have still been sleeping...

@YannickJadoul
Copy link
Member

@mtreinish, do note that you can override these pinned manylinux images, btw, if you need this change reasonably urgently: https://cibuildwheel.readthedocs.io/en/stable/options/#manylinux-image

@mtreinish
Copy link
Contributor Author

@mtreinish, do note that you can override these pinned manylinux images, btw, if you need this change reasonably urgently: https://cibuildwheel.readthedocs.io/en/stable/options/#manylinux-image

Yep, already did :) Qiskit/rustworkx#212 and Qiskit/qiskit-aer#1066 just wanted to make sure that things got updated for everyone

@YannickJadoul
Copy link
Member

Thanks! :-)
Let's merge this, then. I can't see anything wrong with it. And @joerick can still make the decision on whether a release is necessary (but it's maybe less urgent, then).

@YannickJadoul YannickJadoul merged commit e94274d into pypa:master Dec 3, 2020
@mtreinish mtreinish deleted the bump-manylinux2010 branch December 3, 2020 17:03
@joerick
Copy link
Contributor

joerick commented Dec 3, 2020

thanks all! I'll push a new release now

@joerick
Copy link
Contributor

joerick commented Dec 3, 2020

released as v1.7.1

mtreinish added a commit to mtreinish/qiskit-core that referenced this pull request Dec 7, 2020
The linux wheels we publish to PyPI at release time are based on the
manylinux1 [1] and manylinux2010 [2] packaging specifications. To build
these wheels we use the manylinux2010 docker image [3] which is based on
centos 6. Centos 6 recently went end of life and the yum repositories
for it were deleted and an archive url for the yum repositories were
added. However, until the latest manylinux2010 docker image, the images
were configured to use the old url from when the distro was still
supported by upstream. This causes issues when trying to setup a build
[4] because yum will error early during the initial job setup. To fix
this we need to ensure we're using the latest version of the manylinux
2010 docker image, we can either do this manually (as was done in
Qiskit/rustworkx#212 and Qiskit/qiskit-aer#1066) or just update the
cibuildwheel version we're using to the latest release 1.7.1 which
bumped the pinned manylinux2010 docker image used to one with updated
yum urls (see pypa/cibuildwheel#472). This commit bumps the
cibuildwheel version to the latest release so that when it is time to
release terra 0.17.0 the jobs will work as expected.

[1] https://www.python.org/dev/peps/pep-0513/
[2] https://www.python.org/dev/peps/pep-0571/
[3] https://github.com/pypa/manylinux
[4] pypa/manylinux#836
mergify bot added a commit to Qiskit/qiskit that referenced this pull request Dec 9, 2020
* Bump cibuildwheel to latest version

The linux wheels we publish to PyPI at release time are based on the
manylinux1 [1] and manylinux2010 [2] packaging specifications. To build
these wheels we use the manylinux2010 docker image [3] which is based on
centos 6. Centos 6 recently went end of life and the yum repositories
for it were deleted and an archive url for the yum repositories were
added. However, until the latest manylinux2010 docker image, the images
were configured to use the old url from when the distro was still
supported by upstream. This causes issues when trying to setup a build
[4] because yum will error early during the initial job setup. To fix
this we need to ensure we're using the latest version of the manylinux
2010 docker image, we can either do this manually (as was done in
Qiskit/rustworkx#212 and Qiskit/qiskit-aer#1066) or just update the
cibuildwheel version we're using to the latest release 1.7.1 which
bumped the pinned manylinux2010 docker image used to one with updated
yum urls (see pypa/cibuildwheel#472). This commit bumps the
cibuildwheel version to the latest release so that when it is time to
release terra 0.17.0 the jobs will work as expected.

[1] https://www.python.org/dev/peps/pep-0513/
[2] https://www.python.org/dev/peps/pep-0571/
[3] https://github.com/pypa/manylinux
[4] pypa/manylinux#836

* DNM: test wheel jobs

* Revert "DNM: test wheel jobs"

This reverts commit b63071a.

Co-authored-by: Kevin Krsulich <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
chriseclectic pushed a commit to chriseclectic/qiskit-aer that referenced this pull request Dec 11, 2020
The default version of the manylinux2010 docker images used by
cibuildwheel are trying to use a nonexistent yum repository now that
centos 6 is eol. The latest version of the docker image has been
updated. This commit manually sets the docker image to the latest
version to unblock CI. This PR can be reverted when cibuildwheel
releases a new version that bumps their default manylinux2010 version
(see pypa/cibuildwheel#472 for more details on that).
chriseclectic pushed a commit to chriseclectic/qiskit-aer that referenced this pull request Dec 11, 2020
The default version of the manylinux2010 docker images used by
cibuildwheel are trying to use a nonexistent yum repository now that
centos 6 is eol. The latest version of the docker image has been
updated. This commit manually sets the docker image to the latest
version to unblock CI. This PR can be reverted when cibuildwheel
releases a new version that bumps their default manylinux2010 version
(see pypa/cibuildwheel#472 for more details on that).
chriseclectic pushed a commit to chriseclectic/qiskit-aer that referenced this pull request Dec 11, 2020
The default version of the manylinux2010 docker images used by
cibuildwheel are trying to use a nonexistent yum repository now that
centos 6 is eol. The latest version of the docker image has been
updated. This commit manually sets the docker image to the latest
version to unblock CI. This PR can be reverted when cibuildwheel
releases a new version that bumps their default manylinux2010 version
(see pypa/cibuildwheel#472 for more details on that).
@mayeut mayeut mentioned this pull request Dec 20, 2020
chriseclectic pushed a commit to chriseclectic/qiskit-aer that referenced this pull request Jan 25, 2021
The default version of the manylinux2010 docker images used by
cibuildwheel are trying to use a nonexistent yum repository now that
centos 6 is eol. The latest version of the docker image has been
updated. This commit manually sets the docker image to the latest
version to unblock CI. This PR can be reverted when cibuildwheel
releases a new version that bumps their default manylinux2010 version
(see pypa/cibuildwheel#472 for more details on that).
chriseclectic pushed a commit to chriseclectic/qiskit-aer that referenced this pull request Jan 25, 2021
The default version of the manylinux2010 docker images used by
cibuildwheel are trying to use a nonexistent yum repository now that
centos 6 is eol. The latest version of the docker image has been
updated. This commit manually sets the docker image to the latest
version to unblock CI. This PR can be reverted when cibuildwheel
releases a new version that bumps their default manylinux2010 version
(see pypa/cibuildwheel#472 for more details on that).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants