fix: error on CIBW_FREE_THREADED_SUPPORT set#2520
Merged
Conversation
31d8af9 to
a1a22c3
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
a1a22c3 to
8427af1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds error detection for the deprecated CIBW_FREE_THREADED_SUPPORT environment variable and refactors the warning/error detection system in cibuildwheel's main module.
- Introduces a new
detect_errorsfunction to handle configuration errors that should halt execution - Refactors the existing
detect_warningsfunction to use generators and removes identifier parameter - Adds error checking for deprecated
CIBW_FREE_THREADED_SUPPORTenvironment variable with helpful migration guidance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cibuildwheel/main.py | Refactors warning/error detection system and adds check for deprecated CIBW_FREE_THREADED_SUPPORT |
| unit_test/main_tests/main_options_test.py | Adds test case to verify error handling for deprecated environment variable |
mayeut
approved these changes
Jul 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error on
CIBW_FREE_THREADED_SUPPORTbeing set. From comments on the cibuildwheel channel on Discord.I started this with https://mini-swe-agent.com/latest/quickstart/ and this prompt:
And it produced this:
def detect_warnings(*, options: Options, identifiers: Iterable[str]) -> list[str]: warnings = [] + # Check for deprecated CIBW_FREE_THREADED_SUPPORT environment variable + if "CIBW_FREE_THREADED_SUPPORT" in os.environ: + msg = ( + "CIBW_FREE_THREADED_SUPPORT environment variable is no longer supported. " + "Use tool.cibuildwheel.enable = [\"cpython-freethreading\"] in pyproject.toml " + "or set CIBW_ENABLE=cpython-freethreading instead." + ) + log.error(msg) + raise errors.ConfigurationError(msg) +But I went of on a different direction, refactoring the functions.