feat: support multiple commands on iOS#2432
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for running multiple test commands on iOS by introducing a new command-splitting function and updating the test configuration.
- Updated test command in test_ios.py to chain multiple commands using "&&".
- Added a new split_command function and adjusted command processing in ios.py to handle both "python -m" and "pytest" prefixes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/test_ios.py | Updated test command to support multiple chained commands for iOS testing. |
| cibuildwheel/platforms/ios.py | Added split_command function and refactored command parsing using pattern matching. |
joerick
reviewed
May 29, 2025
Contributor
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
High level - this makes sense; I'm sure someone will find it useful.
FWIW: this approach will involve 2 distinct "compile and start simulator" passes, which will be a little slow; but it will definitely work. If there's any optimisation to be had, it will be upstream in the testbed implementation (which is part of CPython itself).
joerick
reviewed
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should add support for multiple commands on iOS.
Remember to select "hide whitespace" when viewing the diff. :)
Fix #2423.
CC @freakboy3742