-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use dependency-groups #2064
Conversation
113616f
to
831a075
Compare
Cirrus: Failed to start an instance: FAILED_PRECONDITION: Monthly compute limit exceeded! Trying to restart now that it's next month. Also, saw this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require to wait for a new nox release as modifications are also needed in the noxfile that require non yet released features of nox.
Nox is just Python, and TOML support was added some time ago. So it's not required to wait for a nox release. I've updated the noxfile. |
f9d716f
to
defaa97
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
defaa97
to
371426a
Compare
Okay to go in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait for pip builtin support to keep workarounds to a minimum ?
Co-authored-by: Matthieu Darbois <[email protected]>
Using a tool to read the dependency groups doesn't seem too bad to me; pip won't support this until 25.1 at the earliest. But we can either put this in of the next release, or the 3.0 release, or wait, this doesn't affect end users, only developers. |
Whats the proposed way to setup a dev environment with this? I still use (I guess if we waited for pip to have support, that would take away this question) |
The non-uv way to do this is to pip/pipx install dependency-groups, then use that to generate the list of items you want to install. It also provides a pip wrapper that installs dependency groups, though I like We can also export this, as I mentioned... somewhere, with Pip PR here: pypa/pip#13065 |
Thanks @henryiii, I've added that info into contributing.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this today, but I'm expecting the pip --group
support to clean this up a bit!
Okay, waiting for @mayeut to update review, then. |
Thanks @henryiii, all good now. |
we missed the gitlab update which only runs on branches in the repo. |
Using dependency groups for cibuildwheel itself.