Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add warning when running cibuildwheel with python<3.11 #2050

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Oct 20, 2024

towards #2047

python_version = ".".join(map(str, python_version_deprecation[0]))
msg = (
f"cibuildwheel {python_version_deprecation[1]}+ will require Python {python_version}+, "
"please upgrade your python version."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"please upgrade your python version."
"please upgrade your Python version used to run cibuildwheel."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling of this message, even with @henryiii suggestion, is that many people will understand that cibuildwheel will build only python 3.11+ wheels.

But I do not have an idea how to rephrase it. Maybe add longer text in docs and add a link to such doc page in message?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add: As always, this does not affect the versions you can target when building wheels. See docs: <link>

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure the commit I just added is the best way to do that but that's the best I could think of.
Having the full matrix of targets just below the sentence "While cibuildwheel itself requires a recent enough python version to run, it can target the following versions to build wheels", I don't think there can be any confusion left.

@mayeut mayeut force-pushed the warn-python-less-3.11 branch from 39b8dd1 to 3fe5b44 Compare October 22, 2024 19:10
README.md Outdated Show resolved Hide resolved
Co-authored-by: Henry Schreiner <[email protected]>
@mayeut mayeut merged commit 7c3b0fb into pypa:main Oct 25, 2024
24 checks passed
@mayeut mayeut deleted the warn-python-less-3.11 branch October 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants