-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bot] Update dependencies #1998
Conversation
I find weird that tests are passing on macOS given the minimum macOS deployment target for Python 3.12 has changed: https://www.python.org/downloads/release/python-3126/ Here's the output I get for Python 3.12.6 on my laptop (& 3.11 just to check there are no overrides in the environment):
|
The min version for macOS jumped to 10.13 for Python 3.12. We’ll need to decide how to handle that. Edit: already addressed, though are we sure this is what we want to do? The only other choice would be to not upgrade Python 3.12. |
IMHO, while I would have preferred not to change the default deployment target for Python 3.12 now, I think it's the best way forward and has probably very little impact for the following reasons:
|
7860f2f
to
32c9be9
Compare
Changing the minimum is unfortunate, but seems okay to me too.
This agrees with my analysis, for what it's worth :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we might want to make this a minor release instead of a patch one for this. (Maybe other things, too, but this seems minor-release worthy, as it will produce different wheels)
This also gives us 3.13.0rc2. |
I would love a new cibuildwheel release with Python 3.13.0rc2. |
I hear you, we're bumping minor so I want to get #1961 in as well, that may well be ready though, I just need to find a few minutes to review it |
What's the timeline on #2002, @agriyakhetarpal? Is that something we'd also like? |
Anything important in rc2, @EwoutH? |
We expect to release Pyodide by the end of September (pyodide/pyodide#5064), so it would be great if #2002 could make it to a |
We are off by one for SerVer, as long as it doesn't break anything existing, the third digit is probably fine. Minor releases can make breaking changes since removing or adding wheels is breaking. |
Okay, so these two PRs are ready to merge, I think? (#1961) |
Sounds great, thanks for the context! #2002 won't block this release, then, and a subsequent patch release with it would be nice. I will get the necessary changes implemented upstream, first. |
Update the versions of our dependencies.
PR generated by "Update dependencies" workflow.