Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rework single python tests #1835

Merged
merged 4 commits into from
May 26, 2024
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 25, 2024

Seeing the many tests that were changed in #1456 to move from one python version to another, we might want a helper for that so that we can do the change in a single location.

Using a single python version is extended to the following tests in order to reduce CI load:

  • test_before_all.py
  • test_before_build.py:test_cwd
  • test_build_skip.py (by updating the skip pattern for the build)
  • test_cpp_standards.py (even though "python version independent" wasn't quite true for PyPy at some point)
  • test_environment.py
  • test_musllinux_X_Y_only.py
  • test_testing.py: test_extras_require

There are also 1 other commits to reduce the load on CI for test_abi3.

@mayeut mayeut marked this pull request as draft May 25, 2024 12:57
@mayeut mayeut force-pushed the single-python-tests branch from d55dbb0 to b879d33 Compare May 25, 2024 15:23
@mayeut mayeut force-pushed the single-python-tests branch from b879d33 to 1a6c152 Compare May 25, 2024 17:39
@mayeut mayeut marked this pull request as ready for review May 25, 2024 17:42
@mayeut mayeut marked this pull request as draft May 25, 2024 18:48
@mayeut mayeut force-pushed the single-python-tests branch from 1a6c152 to 993d1e1 Compare May 25, 2024 19:06
@mayeut mayeut marked this pull request as ready for review May 25, 2024 21:20
@mayeut
Copy link
Member Author

mayeut commented May 26, 2024

I'll apply the same review suggestion as in #1834 (I re-used the same pattern once more in test/test_before_all.py)

use `os.path.samefile` rather than comparing `os.stat` directly.
@mayeut mayeut merged commit 97da904 into pypa:main May 26, 2024
18 of 19 checks passed
@mayeut mayeut deleted the single-python-tests branch May 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants