-
Notifications
You must be signed in to change notification settings - Fork 320
Build Python wheels for windows on travis #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 13 commits
bd583e2
b4249c4
c6965bf
e0b6881
b0cefb6
eddc9c5
e38c203
9003836
1cb337f
6e25817
6d1bf25
6b2d18f
71e889a
db38b33
5746456
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,4 +19,5 @@ def test_build_identifiers(): | |
| # identifiers | ||
| expected_wheels = utils.expected_wheels('spam', '0.1.0') | ||
| build_identifiers = utils.cibuildwheel_get_build_identifiers(project_dir) | ||
| print("bb", build_identifiers) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this, still?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No problem. Very easily overlooked. I was just lucky to notice it ;-) |
||
| assert len(expected_wheels) == len(build_identifiers) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,8 @@ | |
|
|
||
| import subprocess, sys, os | ||
|
|
||
| IS_RUNNING_ON_AZURE = os.path.exists('C:\\hostedtoolcache') | ||
| IS_WINDOWS_RUNNING_ON_AZURE = os.path.exists('C:\\hostedtoolcache') | ||
| IS_WINDOWS_RUNNING_ON_TRAVIS = os.environ.get('TRAVIS_OS_NAME') == 'windows' | ||
|
|
||
|
|
||
| def cibuildwheel_get_build_identifiers(project_path, env=None): | ||
|
|
@@ -38,10 +39,10 @@ def cibuildwheel_run(project_path, env=None, add_env=None): | |
|
|
||
| subprocess.check_call( | ||
| [sys.executable, '-m', 'cibuildwheel', project_path], | ||
| env=env, | ||
| env=env | ||
| ) | ||
|
|
||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A small spurious change left? |
||
| def expected_wheels(package_name, package_version): | ||
| ''' | ||
| Returns a list of expected wheels from a run of cibuildwheel. | ||
|
|
@@ -85,9 +86,12 @@ def expected_wheels(package_name, package_version): | |
| else: | ||
| raise Exception('unsupported platform') | ||
|
|
||
| if IS_RUNNING_ON_AZURE: | ||
| if IS_WINDOWS_RUNNING_ON_AZURE: | ||
| # Python 3.4 isn't supported on Azure. | ||
| templates = [t for t in templates if '-cp34-' not in t] | ||
| if IS_WINDOWS_RUNNING_ON_TRAVIS: | ||
| # Python 2.7 and 3.4 isn't supported on Travis. | ||
| templates = [t for t in templates if '-cp27-' not in t and '-cp34-' not in t] | ||
|
joerick marked this conversation as resolved.
|
||
|
|
||
| return [filename.format(package_name=package_name, package_version=package_version) | ||
| for filename in templates] | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.