minor fixes including python3 fix #14
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ In linux environment, if there was no matching python configurations for a
particular architecture (i.e. if that architecture was skipped) the docker
build script would just crash. The offending line:
for whl in /tmp/linux_wheels/*.whl; do
would result in whl being equal to the unexpanded glob expression. Rather
than checking this in the bash script, python checks whether there are any
actual wheels to build and skips the script if there are none.
+ added universal_newlines=True when making the call to grab the package name -
this fix is required for python3 since other a bytes prefix (b'') will be
added to the package name
+ In the linux/docker environment, added a try/catch statement around the
docker script for KeyboardInterrupt that will kill the docker subprocess in
cases where cibuildwheel is being run interactively.
Contributor
Author
|
BTW this has no relation to recent discussions (e.g. #11) |
Contributor
|
Thanks tgarc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In linux environment, if there was no matching python configurations for a
particular architecture (i.e. if that architecture was skipped) the docker
build script would just crash. The offending line:
for whl in /tmp/linux_wheels/*.whl; do
would result in whl being equal to the unexpanded glob expression. Rather
than checking this in the bash script, python checks whether there are any
actual wheels to build and skips the script if there are none.
added universal_newlines=True when making the call to grab the package name -
this fix is required for python3 since other a bytes prefix (b'') will be
added to the package name
In the linux/docker environment, added a try/catch statement around the
docker script for KeyboardInterrupt that will kill the docker subprocess in
cases where cibuildwheel is being run interactively.