-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactive diagram to the docs #1100
Conversation
Would it make sense to have the png image as a no script fallback, since you already have it? (Or does everything fall apart without JS? Do people still browse without JS sometimes?) |
This looks fantastic, by the way! |
Was going ask about mobile! Noticed it didn’t handle mobile very well when showing it off at PyCon. |
The place you press seems small for going to the link on the second press? |
this looks very nice ! |
Yes, good point. I think I'll change the tap behaviour to be: |
Indeed our docs do use JS for a few things already. But they still basically work so the noscript fallback is a good idea 👍 |
I'm still not sure about the location in the docs, but this will do for the moment I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought I already did this.
Should we merge before release so it gets in the stable docs? |
Wow. That appeared to be very helpful. How it was made? |
@joerick I wanna reuse that. What are the conditions? :D |
Same as the rest of the project, BSD license! https://github.com/pypa/cibuildwheel/blob/main/LICENSE Go for it :) |
Fix #468.
This adds a diagram to the docs that summarises what steps cibuildwheel takes when building a wheel. It's interactive, so mousing over a part will show more info.
One thing I'm not sure about is where to put it in the docs. Currently it's on the 'home' page, it could have its own page. If it had its own page, I could increase the page width a bit too, which might let me increase the font size a bit.