Skip to content

Conversation

@mayeut
Copy link
Member

@mayeut mayeut commented Sep 22, 2019

Add support for manylinux2014 policy
Symbol versions were updated using latest centos:7 docker image by running the updated scripts/calculate_symbol_versions.py

c.f. #185
c.f. pypa/manylinux#338

tests in #193 (I'd rather keep them separated while waiting for official pip and manylinux image)

@codecov

This comment has been minimized.

@mayeut mayeut changed the title WIP - manylinux2014 policy manylinux2014 policy Sep 25, 2019
@mayeut mayeut requested a review from lkollar September 28, 2019 16:07
@mayeut
Copy link
Member Author

mayeut commented Sep 28, 2019

@lkollar,

since you reviewed #141, can you please also review this one to get things going for manylinux2014

Thanks

Copy link
Contributor

@lkollar lkollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few questions.

@di
Copy link
Member

di commented Oct 11, 2019

python/peps#1201 has been merged, is there anything left to do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants