Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preliz dependency #1507

Merged
merged 1 commit into from
Feb 18, 2025
Merged

add preliz dependency #1507

merged 1 commit into from
Feb 18, 2025

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Feb 16, 2025

Description

Preliz is needed for TVPs:

intercept_latent_process = HSGP.parameterize_from_data(
X=time_index, # this is
dims=("date", *self.dims),
**self.model_config["intercept_tvp_config"],
).create_variable("intercept_latent_process")

Is it a big issue to add it?

Maybe numba is the biggest concern? https://github.com/arviz-devs/preliz/blob/7caa9bcc5152e2e413a02c5f757a3f839f975fd9/pyproject.toml#L29

Related Issue

  • Closes #
  • Related to #

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1507.org.readthedocs.build/en/1507/

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (abfb69c) to head (3994050).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1507   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files          52       52           
  Lines        6121     6121           
=======================================
  Hits         5677     5677           
  Misses        444      444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine.

@juanitorduz juanitorduz merged commit 26e80c0 into main Feb 18, 2025
22 checks passed
@juanitorduz juanitorduz deleted the add-preliz-dependency branch February 18, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants