Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix budget allocation plot in case study #1216

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Nov 20, 2024

Closes #1176


📚 Documentation preview 📚: https://pymc-marketing--1216.org.readthedocs.build/en/1216/

@juanitorduz juanitorduz self-assigned this Nov 20, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz added docs Improvements or additions to documentation MMM bug Something isn't working labels Nov 20, 2024
Copy link

review-notebook-app bot commented Nov 20, 2024

View / edit / reply to this conversation on ReviewNB

cluhmann commented on 2024-11-20T20:05:31Z
----------------------------------------------------------------

The alpha=0.7 isn't used in the plots above. Any reason to do it here?


juanitorduz commented on 2024-11-20T20:11:42Z
----------------------------------------------------------------

Good catch! No reason. I removed it.

Copy link

review-notebook-app bot commented Nov 20, 2024

View / edit / reply to this conversation on ReviewNB

cluhmann commented on 2024-11-20T20:05:31Z
----------------------------------------------------------------

Line #2.    fig.suptitle("Response vs spent per channel", fontsize=16);

"spent" should be "Spend"


juanitorduz commented on 2024-11-20T20:11:50Z
----------------------------------------------------------------

Thanks!

Copy link
Contributor

@cluhmann cluhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments.

@juanitorduz juanitorduz requested a review from cluhmann November 20, 2024 20:09
Copy link
Collaborator Author

Good catch! No reason. I removed it.


View entire conversation on ReviewNB

Copy link
Collaborator Author

Thanks!


View entire conversation on ReviewNB

@juanitorduz juanitorduz merged commit a340272 into main Nov 21, 2024
9 checks passed
@juanitorduz juanitorduz deleted the fix-budget-allocation-plot branch November 21, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MMM end to end notebook plot is mislabeled/incorrectly normalized
2 participants