patch values stacked plot #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
=======================================
Coverage 95.59% 95.59%
=======================================
Files 39 39
Lines 4059 4064 +5
=======================================
+ Hits 3880 3885 +5
Misses 179 179 ☔ View full report in Codecov by Sentry. |
juanitorduz
commented
Nov 7, 2024
wd60622
approved these changes
Nov 7, 2024
| @@ -1126,7 +1127,17 @@ def plot_grouped_contribution_breakdown_over_time( | |||
| area_params = dict(stacked=True, ax=ax) | |||
| if area_kwargs is not None: | |||
| area_params.update(area_kwargs) | |||
| all_contributions_over_time.plot.area(**area_params) | |||
| try: | |||
| all_contributions_over_time.plot.area(**area_params) | |||
There was a problem hiding this comment.
Thoughts of check on frame values instead of try except?
There was a problem hiding this comment.
The cheks are done in the plot.area function itself and can have many edge cases. For now lets direct the responsibility to matplotlib 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1148
Simply clip the contributions and add a warning.
📚 Documentation preview 📚: https://pymc-marketing--1181.org.readthedocs.build/en/1181/