Allow Negative Values in Media Channels #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to do tests and docs ⏳ |
juanitorduz
reviewed
Oct 19, 2024
louismagowan
force-pushed
the
allow_negative_values
branch
from
f77de4b to
6e5f622
Compare
juanitorduz
approved these changes
Oct 24, 2024
|
Closes #413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the MMM by default informs our channels to be >=0 via the HalfNormal and inclusion of only non-negative values.
It would be nice to have an option to pass in a column of channels that contain negative values, such that the effect of that channel is allowed to be negative on model target - but while not having to blanket-disable the data validation
validate_data=FalseRelated Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--1092.org.readthedocs.build/en/1092/