Skip parameters the loss cannot reach - #88
Merged
jessegrabowski merged 2 commits intoAug 12, 2026
Conversation
An additive constant is an ancestor of the loss as written and gone once the loss differentiates, so a physics-informed loss could only be trained by enumerating every other parameter by hand. Naming one explicitly still raises, since that asserts it should train.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 96.73% 96.69% -0.05%
==========================================
Files 45 45
Lines 1807 1814 +7
==========================================
+ Hits 1748 1754 +6
- Misses 59 60 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A parameter can be an ancestor of the loss as written and gone once the loss differentiates — an additive output bias under a second derivative.
compile_trainraised on it, so the only way through was to enumerate every other parameter by hand. The collected set now leaves it out; naming it inparameters=still raises, since that asserts it should train.The stop-gradient marker walk has to stay alongside the connection-pattern check.
zero_gradyields a gradient that's connected and zero, so the pattern reports it as present — swapping one for the other puts frozen parameters back in the optimizer's set, where weight decay moves them.