Draw every parameter at construction, and refuse a constant scheme - #84
Merged
jessegrabowski merged 2 commits intoAug 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 95.47% 95.49% +0.01%
==========================================
Files 45 45
Lines 1811 1819 +8
==========================================
+ Hits 1729 1737 +8
Misses 82 82 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A network built and never
.initialize()d couldn't learn. Every weight matrix was created as zeros, so nothing propagated below the last layer and only the output bias moved — the loss still crept down, which reads as slow convergence rather than a bug. Parameters are now drawn from their own initializer when the layer builds them, which incidentally makesLinear("fc", 4, 8, bias_initializer=NormalInitializer())give you that bias instead of silently keeping zeros until someone callsinitialize().Second commit closes the other route to the same dead network:
initialize("zeros")now raises. A constant is the right initializer for one bias or norm scale and never for every weight matrix in a network, so it stays available as a declaration on the parameter that wants it.Construction draws from fresh entropy, so
initialize(seed=...)is still the only thing needed for reproducibility and still overwrites everything.