Let compile_train take extra updates - #76
Merged
jessegrabowski merged 2 commits intoAug 10, 2026
Merged
Conversation
Every state write no gradient produces was shut out of the ergonomic path -- target-network syncs, Polyak averages, replay priorities -- since the only opening collided with this function's own call to the compiler.
That is where a pytensor user looks first, and forwarding it raised a TypeError naming an internal function rather than saying anything useful.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 95.39% 95.42% +0.02%
==========================================
Files 45 45
Lines 1782 1792 +10
==========================================
+ Hits 1700 1710 +10
Misses 82 82 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compile_traincouldn't write state that no gradient produces — a target-network sync, a Polyak average, replay priorities. The obvious workaround,compile_kwargs={"updates": ...}, hit a TypeError naming an internal function.Now there's an
extra_updatesargument, and anupdateskey incompile_kwargsis taken as one. Either spelling raises if it writes a variable the step already writes — a target sync quietly overwriting an optimizer buffer would leave the rule configured but doing nothing.