Read schedules off the clock the rule counts on - #74
Merged
Conversation
compile_train accepts a rule's own advance rather than rejecting it, so a rule's updates keep advancing their counter when compiled directly instead of through compile_train.
The applied rate is an expression over the clock now, so there is no rate variable to publish it to; ask for it as an extra output instead.
Every rule already counted its steps under the name its alias asks for, so the two-clock case the weaker assertion allowed for cannot arise.
The old bound passed with the clock at 1, where the rate is 0.9998, so it did not distinguish an advancing clock from a frozen one.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 93.77% 93.67% -0.10%
==========================================
Files 45 45
Lines 1783 1756 -27
==========================================
- Hits 1672 1645 -27
Misses 111 111 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handing a rule a schedule as its
learning_rateused to substitute it into a rate variable withgraph_replace; now the rule reads it off the step clock it already keeps, andcompile_trainadvances that clock once per step. The rate variable the old path published is gone, so reading the applied rate means asking for it as an extra output, and scheduled rules that kept no step count of their own get a new step-count checkpoint key.