Check for square matrix in make_node to Det

[tanish1729]

Description

Raise a ValueError if non square matrix (with non shapes) is passed to the Det Op

Related Issue

• Closes pt.linalg.det should eagerly fail if known shapes are not square #856

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

[tanish1729]

@jessegrabowski @ricardoV94

[jessegrabowski]

Looks like there are float32 tests failing :)

[ricardoV94]

Failing tests are because of the new scipy release: #859

[jessegrabowski]

Small suggestions for clarity, but otherwise this looks good to me

[jessegrabowski]

Also rebase from the current main to get the scipy version pin; that should fix the failing CI

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.97%. Comparing base (7a00b88) to head (38fb113).
Report is 153 commits behind head on main.

Files with missing lines	Patch %	Lines
pytensor/tensor/nlinalg.py	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
- Coverage   80.99%   80.97%   -0.02%     
==========================================
  Files         169      169              
  Lines       46939    47015      +76     
  Branches    11467    11497      +30     
==========================================
+ Hits        38019    38072      +53     
- Misses       6713     6725      +12     
- Partials     2207     2218      +11     

Files with missing lines	Coverage Δ
pytensor/tensor/nlinalg.py	94.84% <50.00%> (-0.39%)	⬇️

... and 4 files with indirect coverage changes