Declare ndim_supp on value transforms - #8331
Merged
Merged
Conversation
ricardoV94
force-pushed
the
add_ndim_supp_to_transforms
branch
from
June 16, 2026 11:26
0b0ae9d to
286925f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8331 +/- ##
==========================================
+ Coverage 91.71% 91.73% +0.01%
==========================================
Files 128 128
Lines 20649 20668 +19
==========================================
+ Hits 18939 18959 +20
+ Misses 1710 1709 -1
🚀 New features to boost your workflow:
|
Member
|
Looks good, don't understand how it managed to break tests |
jessegrabowski
approved these changes
Jun 16, 2026
ricardoV94
force-pushed
the
add_ndim_supp_to_transforms
branch
from
July 7, 2026 09:22
286925f to
f9c3af4
Compare
ricardoV94
added
the
no releasenotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for knowing whether a transformed variable can retain the dims of the original natural view. Elemwise transforms (ndim=0) trivially can, and these are the most common cases.