Skip to content

VI refactor - using numpyro auto-guide design - #7799

Closed
jessegrabowski wants to merge 11 commits into
pymc-devs:v5from
jessegrabowski:vi-exploration
Closed

VI refactor - using numpyro auto-guide design#7799
jessegrabowski wants to merge 11 commits into
pymc-devs:v5from
jessegrabowski:vi-exploration

Conversation

@jessegrabowski

@jessegrabowski jessegrabowski commented May 23, 2025

Copy link
Copy Markdown
Member

Checking out how VI works with a simple from-scratch implemention


📚 Documentation preview 📚: https://pymc--7799.org.readthedocs.build/en/7799/

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@twiecki

twiecki commented May 24, 2025

Copy link
Copy Markdown
Member

CC @ferrine

@codecov

codecov Bot commented Jun 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.03%. Comparing base (056e80c) to head (0eb9008).
⚠️ Report is 70 commits behind head on v5.

Files with missing lines Patch % Lines
pymc/variational/autoguide.py 0.00% 82 Missing ⚠️
pymc/variational/trainer.py 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v5    #7799      +/-   ##
==========================================
- Coverage   91.44%   91.03%   -0.42%     
==========================================
  Files         116      118       +2     
  Lines       19002    19158     +156     
==========================================
+ Hits        17377    17440      +63     
- Misses       1625     1718      +93     
Files with missing lines Coverage Δ
pymc/variational/trainer.py 0.00% <0.00%> (ø)
pymc/variational/autoguide.py 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theorashid

Copy link
Copy Markdown
Contributor

I've read the notebook. I like the API a lot. I'm a fan of the numpyro guide/autoguide. Nice work

@ricardoV94 ricardoV94 changed the title Exploring VI implementations VI refactor - using numpyro auto-guide design Oct 17, 2025
@ricardoV94
ricardoV94 force-pushed the vi-exploration branch 2 times, most recently from b7aa31d to 3b02bcf Compare January 5, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants