Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass kwargs from pm.Data to aesara.shared #5098

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Conversation

paw-lu
Copy link
Contributor

@paw-lu paw-lu commented Oct 24, 2021

Closes #4967

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Also note #5105 which is slightly related.

pymc/data.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #5098 (748ea70) into main (02b8675) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5098   +/-   ##
=======================================
  Coverage   77.78%   77.78%           
=======================================
  Files          88       88           
  Lines       14115    14115           
=======================================
+ Hits        10979    10980    +1     
+ Misses       3136     3135    -1     
Impacted Files Coverage Δ
pymc/data.py 79.55% <100.00%> (ø)
pymc/bart/pgbart.py 96.61% <0.00%> (+0.37%) ⬆️

@paw-lu paw-lu force-pushed the data-kwargs branch 2 times, most recently from 7a3eb85 to 39e2569 Compare November 5, 2021 01:38
pymc/data.py Show resolved Hide resolved
pymc/data.py Outdated Show resolved Hide resolved
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved from a doc side

@twiecki twiecki merged commit 5f9a2e3 into pymc-devs:main Nov 5, 2021
@twiecki
Copy link
Member

twiecki commented Nov 5, 2021

Thanks @paw-lu!

@paw-lu paw-lu deleted the data-kwargs branch November 5, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pm.Data breaks broadcasting of different shapes
4 participants