switch from pickle/dill to cloudpickle #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4858 +/- ##
==========================================
+ Coverage 72.32% 72.36% +0.03%
==========================================
Files 85 85
Lines 13884 13852 -32
==========================================
- Hits 10042 10024 -18
+ Misses 3842 3828 -14
|
michaelosthege
approved these changes
Jul 13, 2021
|
Great stuff! |
ricardoV94
pushed a commit
to ricardoV94/pymc
that referenced
this pull request
Jul 15, 2021
* use cloudpickle for serialization * add cloudpickle to requirements * update tests for cloudpickle * update release notes with cloudpickle * update conda envs with cloudpickle * remove special case serialization for DensityDist.logp * add pickle import back in for pickle.PickleError * remove strict error message check in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #4856 and (hopefully) preventing future issues with serialization, parallel sampling, etc. This PR also removes the
pickle_backendparameter frompm.sample.@twiecki @michaelosthege