Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove float128 dtype #4514

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Remove float128 dtype #4514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5aef09
Remove float128 dtype which does not exist on Windows and newer OSX v…
twiecki Mar 9, 2021
dd90cb3
Add float128 to release-notes. Add link to memoization PR.
twiecki Mar 9, 2021
89e28a3
Fix linting problem
twiecki Mar 9, 2021
a8d7950
Remove unused imports.
twiecki Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
+ ...

### Maintenance
- The `pymc3.memoize` module was removed and replaced with `cachetools`. The `hashable` function and `WithMemoization` class were moved to `pymc3.util`.
- The `pymc3.memoize` module was removed and replaced with `cachetools`. The `hashable` function and `WithMemoization` class were moved to `pymc3.util` (see [#4509](https://github.com/pymc-devs/pymc3/pull/4509)).
- Remove float128 dtype support (see [#4514](https://github.com/pymc-devs/pymc3/pull/4514)).

## PyMC3 3.11.1 (12 February 2021)

Expand Down
9 changes: 1 addition & 8 deletions pymc3/distributions/dist_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2020 The PyMC Developers
# Copyright 2021 The PyMC Developers
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -17,8 +17,6 @@

@author: johnsalvatier
"""
import platform

import aesara
import aesara.tensor as aet
import numpy as np
Expand All @@ -45,11 +43,6 @@
dtype: (np.nextafter(0, 1, dtype=dtype), np.nextafter(1, 0, dtype=dtype))
for dtype in ["float16", "float32", "float64"]
}
if platform.system() in ["Linux", "Darwin"]:
_beta_clip_values["float128"] = (
np.nextafter(0, 1, dtype="float128"),
np.nextafter(1, 0, dtype="float128"),
)


def bound(logp, *conditions, **kwargs):
Expand Down
11 changes: 2 additions & 9 deletions pymc3/tests/test_dist_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2020 The PyMC Developers
# Copyright 2021 The PyMC Developers
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -11,8 +11,6 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import sys

import aesara
import aesara.tensor as aet
import numpy as np
Expand Down Expand Up @@ -237,12 +235,7 @@ def test_grad(self):
verify_grad(i0e, [[[0.5, -2.0]]])


@pytest.mark.parametrize(
"dtype",
["float16", "float32", "float64", "float128"]
if sys.platform != "win32"
else ["float16", "float32", "float64"],
)
@pytest.mark.parametrize("dtype", ["float16", "float32", "float64"])
def test_clipped_beta_rvs(dtype):
# Verify that the samples drawn from the beta distribution are never
# equal to zero or one (issue #3898)
Expand Down