New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN fix missing newlines #4105

Merged

AlexAndorra merged 1 commit into pymc-devs:master from MarcoGorelli:newlines

Sep 17, 2020

Contributor

MarcoGorelli commented Sep 16, 2020

xref this comment by @twiecki #4076 (comment)

missing new line

How about adding a pre-commit check for this, so that reviewers never have to worry about leaving such a review in the future 😄 ?


          fix missing newlines

c1294f0

Member

twiecki commented Sep 16, 2020 via email

I like that :)

On Wed, Sep 16, 2020, 18:51 Marco Gorelli ***@***.***> wrote: xref this comment by @twiecki <https://github.com/twiecki> #4076 (comment) <#4076 (comment)> missing new line How about adding a pre-commit check for this, so that reviewers never have to worry about leaving such a review in the future 😄 ? ------------------------------ You can view, comment on, or merge this pull request online at: #4105 Commit Summary - fix missing newlines File Changes - *M* .gitignore <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-a084b794bc0759e7a6b77810e01874f2> (1) - *M* .pre-commit-config.yaml <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-82c3b36709926de3a1b27bea0d8258cc> (4) - *M* benchmarks/benchmarks/__init__.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-66e8984c02e5f06df1101c64200c5cbc> (2) - *M* docs/source/Gaussian_Processes.rst <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-671111496f01a6b5c7d7e20e87568082> (2) - *M* docs/source/api/backends.rst <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-4d81c0a3acbe7744a5b43b7e2f872a83> (1) - *M* docs/source/api/data.rst <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-eb91c22a113e72545c1816ed132e6248> (2) - *M* docs/source/api/distributions/utilities.rst <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-0aeb663115e47106848af465e6f06276> (1) - *M* docs/source/api/model.rst <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-91158e86c0ff5622c532526edf6f9032> (1) - *M* docs/source/api/model_graph.rst <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-03c0665f80268b8da55e2b9544153e4a> (1) - *M* docs/source/api/ode.rst <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-1092349bc9b3b68a71e80e570ec85e84> (2) - *M* docs/source/api/variables.rst <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-1af8f88721a8f570d044739834fa64d8> (1) - *M* docs/source/conf.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-1ec61223727a10e5e4c74c68336809fc> (1) - *M* docs/source/semantic_sphinx/static/highlight.min.js <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-9a2eacff900f8cfe2a720e7165bf6dd1> (2) - *M* docs/source/semantic_sphinx/static/semantic.min.js <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-9389f5649ee193ccb23fe499cb0e07b8> (2) - *M* pymc3/distributions/bound.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-cc3b6e5708fc2668e101560b8892b320> (1) - *M* pymc3/distributions/dist_math.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-e87226e0c9d21354a0fdf3a0e166ea18> (2) - *M* pymc3/examples/data/anemones.csv <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-cf1be8087f04e89c43f858b97d6916d6> (2) - *M* pymc3/examples/data/cty.dat <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-880efdfc27b02b0261afd8cc416538ba> (2) - *M* pymc3/gp/mean.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-3e92e6080580878f6e74f66a1e1e8fc8> (1) - *M* pymc3/tests/test_dist_math.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-57663a3b8117a7cbbd151f10771f3b3c> (2) - *M* pymc3/tests/test_hmc.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-7e8d74841426fe1d867c9de0ce50a91b> (1) - *M* pymc3/tests/test_math.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-eacf5948cfb46520b69b94c1fcd92927> (1) - *M* pymc3/tests/test_model_func.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-94f4b803a2c7d544e63f2209858b7498> (3) - *M* pymc3/tests/test_model_graph.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-4476740d614bb60438811287bffda765> (1) - *M* pymc3/tests/test_step.py <https://github.com/pymc-devs/pymc3/pull/4105/files#diff-f7804f3da623e708caf57615e667d83d> (1) Patch Links: - https://github.com/pymc-devs/pymc3/pull/4105.patch - https://github.com/pymc-devs/pymc3/pull/4105.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4105>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFETGC2FVTACQ6I5RT2UY3SGDUJJANCNFSM4RPDX5HQ> .

codecov bot commented Sep 16, 2020 •

edited

Loading

Codecov Report

Merging #4105 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4105   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          89       89           
  Lines       14015    14015           
=======================================
  Hits        12440    12440           
  Misses       1575     1575

Impacted Files	Coverage Δ
pymc3/distributions/bound.py	`91.59% <ø> (ø)`
pymc3/distributions/dist_math.py	`91.79% <ø> (ø)`
pymc3/gp/mean.py	`97.43% <ø> (ø)`

AlexAndorra approved these changes

View reviewed changes

Contributor

AlexAndorra left a comment

Looks neat, thanks @MarcoGorelli ! Don't know why it changed some JS files though 🤷‍♂️
Also, how would devs go ahead and apply that in their PR workflow?

Contributor Author

MarcoGorelli commented Sep 16, 2020 •

edited

Loading

Looks neat, thanks @MarcoGorelli !

👍

Don't know why it changed some JS files though man_shrugging

Pre-commit isn't a Python-specific tool. This particular hook will run against lots of different types of files, if they don't have newlines at the end (like the JS files modified here didn't) it'll add them

Also, how would devs go ahead and apply that in their PR workflow?

If they install pre-commit, the pre-commit checks will run against any files they've modified when they do git commit

Contributor

AlexAndorra commented Sep 17, 2020

Sounds good! Thanks a lot @MarcoGorelli 👌

AlexAndorra merged commit d1ebb00 into pymc-devs:master

MarcoGorelli deleted the newlines branch

September 17, 2020 08:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet