-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deprecation warnings for old backends #3902
add deprecation warnings for old backends #3902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am, in general, super in favor of this!
My only reservation is that save_trace
/load_trace
is currently the only non-pickle way of reloading a trace to, for example, do ppc sampling. I'm sort of ok going back to suggesting pickle unless someone has a reasonable security reason not to.
Codecov Report
@@ Coverage Diff @@
## master #3902 +/- ##
==========================================
+ Coverage 83.41% 83.42% +0.01%
==========================================
Files 103 103
Lines 14190 14203 +13
==========================================
+ Hits 11836 11849 +13
Misses 2354 2354
|
Co-authored-by: Colin <[email protected]>
|
😻 deprecate and merge away, then! |
If we are going to deprecate save and load trace, shouldn't we go the further step of making It seems like we shouldn't leave things in a state where we deprecate saving and loading It also seems like we should revisit @aseyboldt 's idea of making PyMC3 variable creation support a |
I'm all in for returning I'll do a PR tomorrow to add |
* updated the Hogg notebook * attempted to clarify the kwargs in sample() docstring describing how to pass kwargs to the steppers I believe this fixes #3197 I also noted this need for more clarity in my updated notebook in this PR `pymc3/docs/source/notebooks/GLM-robust-with-outlier-detection.ipynb` * Remove deprecated stuff (#3906) * remove file which is not used * remove deprecated code * repair tests and notebooks that used deprecated API * mention #3906 Co-authored-by: Michael Osthege <[email protected]> * add deprecation warnings for old backends (#3902) * add deprecation warnings for old backends * mention backend deprecation #3902 * fix typo Co-authored-by: Colin <[email protected]> Co-authored-by: Michael Osthege <[email protected]> Co-authored-by: Colin <[email protected]> * minor formatting to notebook and rework of docstring for sample function notebook: dropped all headings one level lower to comply with TOC logic, and very minor language edits sampling.py: clarifired language around single vs compoundstep * updated the Hogg notebook * attempted to clarify the kwargs in sample() docstring describing how to pass kwargs to the steppers I believe this fixes #3197 I also noted this need for more clarity in my updated notebook in this PR `pymc3/docs/source/notebooks/GLM-robust-with-outlier-detection.ipynb` * minor formatting to notebook and rework of docstring for sample function notebook: dropped all headings one level lower to comply with TOC logic, and very minor language edits sampling.py: clarifired language around single vs compoundstep * updates folowing AlexAndorra review: upgrade to arviz=0.7 set prior params to slightly simpler (more justifiable) values, and testvals to simplier defaults explanatory clarifications formatting, typos, * removed the note re step_kwargs, since this PR updates the appropriate docstring * a cell had become markdown, silly. reset it to code and rerun * minor code reformatting via black_nbconvert, final check and re-run * rerun notebook purely as a lazy but safe way to trigger new CI
Some old backends are cluttering the codebase. We don't know of anybody still using them, so this PR adds deprecation warnings.
I'll add a line to the release notes just in case anybody ignores warnings..