Remove numdifftools

[ColCarroll]

This fixes a problem from #3468, and also one that @twiecki brought up in pbrod/numdifftools#42, specifically: the most current version of numdifftools on pypi uses an old version of scipy.

I do not entirely understand what this code is doing, but I get the impression we are using numdifftools for more experimental stuff, which I have just removed.

If anyone is concerned, I can do more research into what exactly this is doing, but no PRs will pass CI until we do one of the following, in my order of preference:

• remove numdifftools (this approach)
• install numdifftools from github in requirements-dev.txt
• pin scipy to an earlier verison
• something else?

[twiecki]

I'm in favor of removing it.

…

On Tue, May 21, 2019, 04:13 Colin ***@***.***> wrote: This fixes a problem from #3468 <#3468>, and also one that @twiecki <https://github.com/twiecki> brought up in pbrod/numdifftools#42 <pbrod/numdifftools#42>, specifically: the most current version of numdifftools on pypi uses an old version of scipy. I do not entirely understand what this code is doing, but I get the impression we are using numdifftools for more experimental stuff, which I have just removed. If anyone is concerned, I can do more research into what exactly this is doing, but no PRs will pass CI until we do one of the following, in my order of preference: - remove numdifftools (this approach) - install numdifftools from github in requirements-dev.txt - pin scipy to an earlier verison - something else? ------------------------------ You can view, comment on, or merge this pull request online at: #3485 Commit Summary - Remove numdifftools File Changes - *M* pymc3/tests/test_distributions.py <https://github.com/pymc-devs/pymc3/pull/3485/files#diff-0> (39) - *M* pymc3/tuning/__init__.py <https://github.com/pymc-devs/pymc3/pull/3485/files#diff-1> (2) - *M* pymc3/tuning/scaling.py <https://github.com/pymc-devs/pymc3/pull/3485/files#diff-2> (36) - *M* requirements-dev.txt <https://github.com/pymc-devs/pymc3/pull/3485/files#diff-3> (1) Patch Links: - https://github.com/pymc-devs/pymc3/pull/3485.patch - https://github.com/pymc-devs/pymc3/pull/3485.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3485>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFETGGFKAGO343WCNOMYVLPWNLEZANCNFSM4HOGYSUA> .

[twiecki]

Thought about this some more and this is a pretty obvious case, we don't need a decaying dependency for just a single test.

************* Module pymc3.tests.test_distributions
pymc3/tests/test_distributions.py:6: [W0611(unused-import), ] Unused Potential imported from model
pymc3/tests/test_distributions.py:7: [W0611(unused-import), ] Unused DictToArrayBijection imported from blocking
pymc3/tests/test_distributions.py:7: [W0611(unused-import), ] Unused ArrayOrdering imported from blocking

[twiecki]

Also needs release-notes.

[lucianopaz]

Thanks @ColCarroll!