Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix for timeout in graph_model #3460

Merged
merged 4 commits into from
May 5, 2019
Merged

[WIP] Fix for timeout in graph_model #3460

merged 4 commits into from
May 5, 2019

Commits on May 5, 2019

  1. Revise _get_ancestors to use BFS. 

    Previously, `get_ancestors()` used a powerset computation, which would fail on large models. Replaced with breadth-first search.
    @rpgoldman
    rpgoldman committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f76df8c View commit details
    Browse the repository at this point in the history

  2. Simplify _get_ancestors(). 

    Per @lucianopaz. remove the initial special case/
    @rpgoldman
    rpgoldman committed May 5, 2019
    Configuration menu
    Copy the full SHA
    8981c7e View commit details
    Browse the repository at this point in the history

  3. Remove unused _ancestors method 

    New Breadth-first search version of _get_ancestors no longer uses it.
Also added some type annotations to clarify.
    @rpgoldman
    rpgoldman committed May 5, 2019
    Configuration menu
    Copy the full SHA
    9f3bba0 View commit details
    Browse the repository at this point in the history

  4. Release note for PR pymc-devs#3460

    @rpgoldman
    rpgoldman committed May 5, 2019
    Configuration menu
    Copy the full SHA
    ca13c44 View commit details
    Browse the repository at this point in the history