Fixed bug in drawing of graphviz edges from interaction nodes #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acing colons in node names with ampersands. Ampersands are a safe replacement: they will not cause accidental node name collisions because they aren't allowed in python names (nor, by extension, in patsy formulas).
|
LGTM when tests pass. |
|
travis checks failed, but it does not appear related to this PR. |
|
thanks @jvparidon! |
twiecki
pushed a commit
to canyon289/pymc
that referenced
this pull request
Apr 16, 2019
…acing colons in node names with ampersands. (pymc-devs#3414) Ampersands are a safe replacement: they will not cause accidental node name collisions because they aren't allowed in python names (nor, by extension, in patsy formulas).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3413, drawing of graphviz edges from interaction nodes by replacing colons in node names with ampersands.
Ampersands are a safe replacement: they will not cause accidental node name collisions because they aren't allowed in python names (nor, by extension, in patsy formulas).