replace math.exp with np.exp

[junpenglao]

math.exp return overflow error when input is too large. Switching to np.exp resolves this.

[springcoil]

Is a regression test needed?

…

On Fri, 20 Apr 2018, 1:58 pm Junpeng Lao, ***@***.***> wrote: math.exp return overflow error when input is too large. Switching to np.exp resolves this. ------------------------------ You can view, comment on, or merge this pull request online at: #2939 Commit Summary - math.exp to np.exp File Changes - *M* pymc3/step_methods/hmc/hmc.py <https://github.com/pymc-devs/pymc3/pull/2939/files#diff-0> (4) - *M* pymc3/step_methods/step_sizes.py <https://github.com/pymc-devs/pymc3/pull/2939/files#diff-1> (16) Patch Links: - https://github.com/pymc-devs/pymc3/pull/2939.patch - https://github.com/pymc-devs/pymc3/pull/2939.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2939>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA8DiLKE6TTCb1RLBGeB_VpXaVnXJ1jSks5tqduPgaJpZM4Tda48> .

[ColCarroll]

I think now instead of throwing an error, it will (silently) pass on a float('inf'), which hopefully other machinery can deal with more intelligently. At worst this will change the error that appears, and at best, it allows more models to be fit, right?

Specifically, I don't think we need a regression test.

[junpenglao]

I think now instead of throwing an error, it will (silently) pass on a float('inf'), which hopefully other machinery can deal with more intelligently.

Exactly.

[springcoil]

Ok just asking

…

On Fri, 20 Apr 2018, 2:28 pm Junpeng Lao, ***@***.***> wrote: I think now instead of throwing an error, it will (silently) pass on a float('inf'), which hopefully other machinery can deal with more intelligently. Exactly. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2939 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA8DiLE6NMY6ZNdJ_Xrv513gKQGcwVatks5tqeJmgaJpZM4Tda48> .