fix GARCH11: missing [] in tt.concatenate()#2937
Merged
springcoil merged 2 commits intopymc-devs:masterfrom Apr 20, 2018
Merged
fix GARCH11: missing [] in tt.concatenate()#2937springcoil merged 2 commits intopymc-devs:masterfrom
springcoil merged 2 commits intopymc-devs:masterfrom
Conversation
Contributor
|
Good catch :) Could you add a little test to this too? |
springcoil
approved these changes
Apr 20, 2018
Contributor
springcoil
left a comment
springcoil
left a comment
There was a problem hiding this comment.
LGTM, is there a test for this though?
Member
|
I am surprised that we dont have any test for GARCH11. |
Contributor
|
Maybe a different commit - something to be opened up. |
Closed
Contributor
Author
|
Sorry, didn't follow your discussion while working on the test. Just tried to create something similar to the AR test, will see if it passes. |
Member
|
@smartass101 nicely done ;-) |
Contributor
|
Looks awesome. I was going to have a go this afternoon. Well done
…On Fri, 20 Apr 2018, 1:56 pm Junpeng Lao, ***@***.***> wrote:
@smartass101 <https://github.com/smartass101> nicely done ;-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2937 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA8DiAduA3lN1_89ePY47HRLGOEi4Adeks5tqdsagaJpZM4TdXkU>
.
|
smartass101
force-pushed
the
fix_GARCH11
branch
from
250b62e to
f981329
Compare
smartass101
force-pushed
the
fix_GARCH11
branch
from
f981329 to
910396e
Compare
Contributor
|
Well done :) Welcome @smartass101 on your first commit :) |
agustinaarroyuelo
pushed a commit
to agustinaarroyuelo/pymc3
that referenced
this pull request
Feb 8, 2019
* fix GARCH11: missing [] in tt.concatenate() * add test for GARCH11 and update docstring to current standards Closes pymc-devs#2938
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a simple fix, not sure if it ever worked without it.
close #2938