Removed redundant specification of version number

[fonnesbeck]

The package version currently resides in 4 different places. This change eliminates all but one, making maintenance easier.

[ColCarroll]

I'm pretty sure this fails on pip install because it will import pymc3 before installing requirements (trying pip install -e . locally fails because numpy isn't yet installed. Will probably pass on travis since we install dependencies separately.

I have used the pattern from https://github.com/pypa/pip/blob/master/setup.py to only define the version in 1 place before (essentially, read the __init__.py file, and use a regex to parse out the version).

[fonnesbeck]

I tested it locally with pip install -e . into a clean virtualenv and had no errors.

[twiecki]

@fonnesbeck that's because you ran this from the pymc3 root dir which allows import pymc3 to work. I think a better solution is to use versioneer. https://github.com/warner/python-versioneer

[fonnesbeck]

No, this installs fine when installed from elsewhere too.

$ pip install -e Repos/pymc3 

I'd prefer not to invoke a third-party package if possible.

[fonnesbeck]

I think as long as the import does not try to access any compiled code, this works fine.

[ColCarroll]

That's super strange. Importing pymc3 should import numpy et al.

…

On Wed, Apr 11, 2018, 9:58 AM Chris Fonnesbeck ***@***.***> wrote: I think as long as the import does not try to access any compiled code, this works fine. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2926 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACMHEEwc97BFBgsqHm-UHoaDhNngLWDeks5tngvngaJpZM4TPNcc> .

[fonnesbeck]

@ColCarroll actually, I'm sure you are right. My virualenv is probably falling back on a global site-packages. I will try your regex approach.

[ColCarroll]

looks like stray characters here

[fonnesbeck]

Are we okay with this?

[ColCarroll]

Yep!