Merged
Conversation
Member
|
LGTM. I agree sampling from the prior would be better, but for now using the test_val should be enough (plus we can provide a random value to the test_val in the initialization). |
aseyboldt
force-pushed
the
fix-adapt-init
branch
2 times, most recently
from
d77962a to
0147b81
Compare
aseyboldt
force-pushed
the
fix-adapt-init
branch
from
0147b81 to
01d1fcb
Compare
aseyboldt
force-pushed
the
fix-adapt-init
branch
from
01d1fcb to
f0b6ba1
Compare
Member
Author
|
I just disabled that test with the warnings for now. Not exactly a solution, but the only thing I can think of at this point. |
Member
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #2442. This changes the initialization from using a draw from the prior to using the test_point. I think I like a draw from the prior more, but we can't do this reliably yet.
I also allowed the test for the warnings in the posterior check of nuts to fail. I just can't find the issue there, and I don't see the point of keeping to restart test runs because of this. If anyone has an idea what that is about, that would be great. I spend quite a bit of time trying to find out, but still don't even have a clue.
CC @junpenglao