Run lint before tests, so travis fails faster#2461
Merged
springcoil merged 1 commit intopymc-devs:masterfrom Aug 11, 2017
Merged
Run lint before tests, so travis fails faster#2461springcoil merged 1 commit intopymc-devs:masterfrom
springcoil merged 1 commit intopymc-devs:masterfrom
Conversation
Member
|
It will fail faster on linting issues, but will take longer for bugs, no? |
Member
|
linting is usually quite fast, so I don't think that should be that much of a problem, right? |
Member
Author
|
Yeah -- this just addresses the sometimes troubling 30 minute wait to realize you didn't put spaces around an |
Member
|
Fair enough. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should just allow a faster failure on lint errors on travis.