Skip to content

Deprecated Constant class #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springcoil merged 10 commits into from
Aug 11, 2017
Merged

Deprecated Constant class #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9828b36
Moved Constant to subclass of Continuous
fonnesbeck Jul 28, 2017
8405188
Added missing distributions from distributions api docs
fonnesbeck Jul 28, 2017
d127b26
Changed Constant to be subclass of Distribution
fonnesbeck Jul 28, 2017
cfec6ae
Reverted changes and added deprecation warning for Constant
fonnesbeck Aug 3, 2017
8b85810
Moved Constant reference in init
fonnesbeck Aug 3, 2017
23b9915
Merge branch 'master' into continuous_constant
fonnesbeck Aug 3, 2017
35912ab
Moved Constant reference in init
fonnesbeck Aug 3, 2017
369ae4b
Added Constant to discrete.rst
fonnesbeck Aug 3, 2017
50941e1
Fixed import error
fonnesbeck Aug 3, 2017
cbaa3dc
Removed duplicate/redundant warning for ConstantDist
fonnesbeck Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions docs/source/api/distributions/continuous.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,28 @@ Continuous

Uniform
Flat
HalfFlat
Normal
HalfNormal
SkewNormal
Beta
Exponential
Laplace
StudentT
StudentTpos
Cauchy
HalfCauchy
Gamma
Weibull
StudentTpos
Lognormal
ChiSquared
HalfNormal
Wald
Pareto
InverseGamma
ExGaussian
VonMises
Triangular
Gumbel

.. automodule:: pymc3.distributions.continuous
:members:
5 changes: 4 additions & 1 deletion docs/source/api/distributions/discrete.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,18 @@ Discrete
.. autosummary::

Binomial
ZeroInflatedBinomial
BetaBinomial
Bernoulli
Poisson
ZeroInflatedPoisson
NegativeBinomial
ConstantDist
ZeroInflatedPoisson
DiscreteUniform
Geometric
Categorical
DiscreteWeibull
Constant

.. automodule:: pymc3.distributions.discrete
:members:
9 changes: 4 additions & 5 deletions pymc3/distributions/discrete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import theano
import theano.tensor as tt
from scipy import stats
import warnings

from pymc3.util import get_variable_name
from .dist_math import bound, factln, binomln, betaln, logpow
Expand Down Expand Up @@ -555,6 +556,8 @@ class Constant(Discrete):
"""

def __init__(self, c, *args, **kwargs):
warnings.warn("Constant has been deprecated. We recommend using a Determinstic object instead.",
DeprecationWarning)
super(Constant, self).__init__(*args, **kwargs)
self.mean = self.median = self.mode = self.c = c = tt.as_tensor_variable(c)

Expand All @@ -578,11 +581,7 @@ def _repr_latex_(self, name=None, dist=None):
return r'${} \sim \text{{Constant}}()$'.format(name)


def ConstantDist(*args, **kwargs):
import warnings
warnings.warn("ConstantDist has been deprecated. In future, use Constant instead.",
DeprecationWarning)
return Constant(*args, **kwargs)
ConstantDist = Constant


class ZeroInflatedPoisson(Discrete):
Expand Down