Conversation
aseyboldt
left a comment
There was a problem hiding this comment.
I wrote down some random stuff, feel free to ignore if you don't agree (english isn't even my native language after all ;)
| :Web site: https://github.com/pymc-devs/pymc3 | ||
|
|
||
|
|
||
| Purpose |
There was a problem hiding this comment.
I don't think we need a section title. It's kind of obvious that we introduce pymc here :-)
docs/source/intro.rst
Outdated
| Purpose | ||
| ======= | ||
|
|
||
| PyMC3 is a probabilistic programming module for Python that allows users to fit Bayesian models using a variety of numerical methods, most notably, Markov chain Monte Carlo (MCMC) and variational inference (VI). Its flexibility and extensibility make it applicable to a large suite of problems. Along with core model specification and fitting functionality, PyMC3 includes methods for summarizing output, plotting, goodness-of-fit and model diagnostics. |
There was a problem hiding this comment.
The rules for commas in English are a bit of a mystery to me, but do we need the comma after "most notably"?
"suite of problems" sounds a bit strange to me (but there are a lot of google hits, so maybe that is a thing after all). How about something like "It it being used in biology, astronomy, physics, the social sciences, business and finance and can be extended to fit new needs" (we might want to check that list however). I guess that would cover "flexibility".
Maybe "... fitting functionality, PyMC3 can visualize its results and provides model diagnostics."?
docs/source/intro.rst
Outdated
| Features | ||
| ======== | ||
|
|
||
| PyMC3 strives to make Bayesian modeling as simple and painless as possible, thereby allowing users to focus on their scientific problem, rather than on the methods used to solve it. Here is a partial list of its features: |
There was a problem hiding this comment.
"thereby allowing" -> "to allow"?
I don't think we need the second sentence. Clear from context.
docs/source/intro.rst
Outdated
|
|
||
| PyMC3 strives to make Bayesian modeling as simple and painless as possible, thereby allowing users to focus on their scientific problem, rather than on the methods used to solve it. Here is a partial list of its features: | ||
|
|
||
| * Fits Bayesian statistical models using modern techniques, including MCMC and VI. |
There was a problem hiding this comment.
Third person sounds a bit strange. Maybe imperative? Or just "Modern techniques for fitting Bayesian stats models..."
Replace MCMC by hamiltonian MCMC and no abbreviations.
docs/source/intro.rst
Outdated
|
|
||
| * Uses Theano as the computational backend, allowing for fast expression evaluation, automatic gradient calculation, and GPU computing. | ||
|
|
||
| * Includes a module for Gaussian process modeling. |
There was a problem hiding this comment.
"Build-in support for Gaussian process modeling"
docs/source/intro.rst
Outdated
|
|
||
| * Creates summaries including tables and plots. | ||
|
|
||
| * Several convergence diagnostics are available. |
There was a problem hiding this comment.
"Model checking and convergence detection"
| with the full power of Python. | ||
|
|
||
|
|
||
| What's new in version 3 |
There was a problem hiding this comment.
Mabe just mention that it is a rewrite, but not much detail. That could be on a separate page pymc2 vs pymc3. I could be very wrong about this, but so far I didn't have the impression that most pymc3 users also knew pymc2. For those users the comparison is kind of pointless. Also, this kind of ends up repeating the feature list from above.
The important part of this is I think mentioned in the history section.
There was a problem hiding this comment.
I've tried to restrict this list to differences. We do get a fair number of users moving over, and probably will get more now that v.3 is released.
docs/source/intro.rst
Outdated
|
|
||
| First, import the PyMC3 functions and classes you will need for building your model. You can import the entire module via `import pymc3 as pm`, or just bring in what you need:: | ||
|
|
||
| from pymc3 import Model, Normal, invlogit, Binomial, sample, traceplot |
There was a problem hiding this comment.
Pretty much everywhere we are using import pymc3 as pm. So I think we should do the same thing here.
There was a problem hiding this comment.
Both are valid. I've noted the option for pm above.
docs/source/intro.rst
Outdated
| theta = invlogit(alpha + beta*dose) | ||
|
|
||
| # Model likelihood | ||
| deaths = Binomial('deaths', n=n, p=theta, observed=np.array([0, 1, 3, 5])) |
There was a problem hiding this comment.
Move the definition of the observations before the model def?
docs/source/intro.rst
Outdated
|
|
||
| Save this file, then from a python shell (or another file in the same directory), call:: | ||
|
|
||
| with bioassay_model: |
There was a problem hiding this comment.
I don't se a problem locally. I will double check.
|
Thanks! I've integrated several of these suggestions. |
|
@fonnesbeck Is this finished? |
|
Yeah, I think so. It can be improved with subsequent PRs if desired. |
No description provided.