Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove InferenceData object warning from v4 #4740

Closed
twiecki opened this issue Jun 5, 2021 · 2 comments
Closed

Remove InferenceData object warning from v4 #4740

twiecki opened this issue Jun 5, 2021 · 2 comments
Labels
beginner friendly v4

Comments

@twiecki
Copy link
Member

twiecki commented Jun 5, 2021

Currently v4 still displays:

FutureWarning: In v4.0, pm.sample will return an `arviz.InferenceData` object instead of a `MultiTrace` by default. You can pass return_inferencedata=True or return_inferencedata=False to be safe and silence this warning.

when calling pm.sample(). Need to remove and set return_inferencedata=True.
@michaelosthege
Copy link
Member

The issue exists already and is part of the v4 milestone: #4372

michaelosthege added a commit to michaelosthege/pymc that referenced this issue Jun 6, 2021
@michaelosthege
Return InferenceData by default
d6e98da 
Also removes some unnecessary XFAIL marks.

Closes pymc-devs#4372, pymc-devs#4740
@michaelosthege michaelosthege mentioned this issue Jun 6, 2021
Merged
6 tasks
michaelosthege added a commit to michaelosthege/pymc that referenced this issue Jun 6, 2021
@michaelosthege
Return InferenceData by default
ca3c236 
Also removes some unnecessary XFAIL marks.

Closes pymc-devs#4372, pymc-devs#4740
michaelosthege added a commit to michaelosthege/pymc that referenced this issue Jun 7, 2021
@michaelosthege
Return InferenceData by default
e0d261d 
Also removes some unnecessary XFAIL marks.

Closes pymc-devs#4372, pymc-devs#4740
michaelosthege added a commit to michaelosthege/pymc that referenced this issue Jun 7, 2021
@michaelosthege @OriolAbril
Return InferenceData by default
a584af1 
Also removes some unnecessary XFAIL marks.

Closes pymc-devs#4372, pymc-devs#4740

Co-authored-by: Oriol Abril <[email protected]>
michaelosthege added a commit that referenced this issue Jun 7, 2021
@michaelosthege @OriolAbril
Return InferenceData by default
0923d25 
Also removes some unnecessary XFAIL marks.

Closes #4372, #4740

Co-authored-by: Oriol Abril <[email protected]>
@michaelosthege
Copy link
Member

Closed by 0923d25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twiecki @michaelosthege