Skip to content

Change **kargs to **kwargs #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
canyon289 opened this issue Apr 12, 2021 · 1 comment · Fixed by #4651
Closed

Change **kargs to **kwargs #4630

canyon289 opened this issue Apr 12, 2021 · 1 comment · Fixed by #4651
Labels
beginner friendly

Comments

@canyon289
Copy link
Member

While the definition **kargs is arbitrary and functional in python it is inconsistent with both convention **kwargs and with the kwargs operator spelled per convention in the same class multiple time below

https://github.com/pymc-devs/pymc3/blob/master/pymc3/model.py#L282
https://github.com/pymc-devs/pymc3/blob/master/pymc3/model.py#L305
@Swanand01
Copy link
Contributor

Hi. I am a first time contributor to open source and I would like to take this up.

@michaelosthege michaelosthege mentioned this issue Jun 5, 2021
Merged
6 tasks
michaelosthege pushed a commit that referenced this issue Jun 5, 2021
@Swanand01
Updated fastfn docstring and renamed kargs to kwargs (#4651)
84110de 
Closes #4630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the documentation for the fastfn function with default argume…
3 participants
@michaelosthege @canyon289 @Swanand01